This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix crash on OS X node tests #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkaefer
approved these changes
Jul 21, 2017
platform/node/index.js
Outdated
| @@ -19,7 +19,12 @@ var Map = function(options) { | |||
| return new constructor(Object.assign(options, { | |||
| request: function(req) { | |||
| request(req, function() { | |||
| req.respond.apply(req, arguments); | |||
| var args = arguments; | |||
| // Protect ourselves from `request` implementations that try to release Zalgo. | |||
There was a problem hiding this comment.
Not sure what Zalgo is without googling. Can we use a clearer phrasing of the issue here please?
There was a problem hiding this comment.
Sorry, that was overly snarky. I've rephrased the comment, and kept the link for further background.
There was a problem hiding this comment.
Yeah, I saw the link, but even then it took me a while to understand that it refers to a meme. Thanks for updating!
platform/node/index.js
Outdated
| var args = arguments; | ||
| // Protect ourselves from `request` implementations that try to release Zalgo. | ||
| // http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony | ||
| setImmediate(function() { |
There was a problem hiding this comment.
Any reason to use setImmediate instead of process.nextTick?
There was a problem hiding this comment.
Not really. Sounds like process.nextTick is in fact more "immediate" than setImmediate. It probably doesn't matter though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8812.